$ cat ~/.ssh/id_rsa.pub
Then Then paste your public key into the box on your account settings page at http://bugs.illumos.org and save the changes. Wait for a while for the change to propagate to the webrev server.
Note if you leave your
passphrase blank you will be able to both publish and delete your webrev's as per the latest instructions on the main page at http://cr.illumos.org/ (this both creates and uploads your webrev - see "Creating and Uploaded in one step" ) however if you use a
passphrase you will not be able to delete your webrev's as only publish will ask you for your
and uploading a webrev
webrev tool The weberev tool is an easy way to show other people changes you have made. It presents changes (including commit messages) in multiple formats viewable from a web browser. If you have installed an illumos build, you can run webrev like this:
/opt/onbld/bin/webrev -O -o illumos-123-webrev
Else, from your workspace if you have built the tools:
ksh93 bldenv.sh illumos.sh -c 'webrev -O -o illumos-123-webrev'
Or to use webrev provided by installed ON build tools on a non-illumos system:
/opt/onbld/bin/webrev -I usr/src/tools/scripts/its.reg -O -o illumos-123-webrev'
Note: The reason reason for the -I option is to provide links to our issue tracker. If you see
*** failed to import extension hgext.cdm from .../usr/src/tools/proto/root_i386-nd/opt/onbld/lib/python2.6/onbld/hgext/cdm.py: cannot import name WorkList, try running webrev from the workspace instead.
Upload the directory somewhere people can access it from the web, such as a personal web site.
zip -r illumos-123-webrev.zip illumos-123-webrev
Then add the file on cr.illumos.org and click "Publish". Warning there appears to no longer be a "Publish" as such you should follow the next section "Creating and uploading a webrev in one step". There is may still be a way to upload your webrev as created above, however the next "all at once create and upload" seems to be the currently preferred method.
Creating and uploading a webrev in one step
It seems that the "Publish" button is no longer available on http://cr.illumos.org/ as such the prior section can not be used to upload a webrev.
Currently in order to publish a webrev, you'll first need to make sure your SSH key is up-to-date in redmine (in https://www.illumos.org/my/account ) - refer to instructions above in "Generate a key pair". Then, you can use webrev(1) to generate and upload your webrev, all at once in a single step (to both create and upload your webrev), thus:
webrev -t rsync://firstname.lastname@example.org:SOME_NAME -O -U
You can delete a previously uploaded webrev thus:
webrev -t rsync://email@example.com:SOME_NAME -D
Note that SOME_NAME is an arbitrary string that will form part of the URL to your webrev. This is not your user name but rather a descriptive name of the issue and/or fix. Note, also, that you should always use "webrev@" in the rsync URL, not your redmine username.
Once uploaded, your webrev will be in your directory here: http://cr.illumos.org/~webrev for example assuming your login name is jondoe and your SOME_NAME is 1023 the final webrev will be located as SOME_NAME e.g.1023 under your directory http://cr.illumos.org/~webrev/jondoe/ or with a complete path of http://cr.illumos.org/~webrev/jondoe/1023
Ensuring adequate review
It is up to you as a contributor to gather reasonable review to satisfy your RTI advocate that the code is correct and of high quality. Exactly what this means will vary based on the nature and scope of the change, but here are some guidelines that will give the advocates confidence in your changes. As always, trust your avocate and apply "shrink to fit".