Advocates are the gatekeepers to the illumos core: they have the ultimate say in what code is accepted, and their primary job is to ensure quality and stability for all illumos users.
Advocates are appointed by the illumos Developers' Council, a technical steering committee drawn from well-known developers of Solaris, whose role is to make high-level architecture decisions.
Current membership of the Dev Council:
|Name||Affiliation||Areas of Expertise||irc nick on #illumos|
Storage targets and HBAs, misc drivers,
|Dan McDonald||Joyent||TCP/IP, Cryptography, Networking userland,|
GLDv3, some COMSTAR, etc.
|Robert Mustacchi||Joyent||Virtualization, Pieces of SMF, PCI, MDB, |
DTrace, x86 platform, etc.
(other misc. stuff)
|Joshua M. Clulow||Joyent||LeftWing|
Contributors send you patches, build results, test results, check results, review results. If you're happy with all of this, you integrate the change on their behalf.
You should have received a diff in hg export or similar format, including a full set of metadata (Reviewed by: lines, authorship, etc.). If you didn't, feel free to ask whoever submitted the patch to submit it in this format, you shouldn't have to go search the list archives for reviewers.
The whole reason we have RTI advocates or, if you're not steeped in Sun-ish history, follow a "pull" model, is that it provides us with a step in the process where in theory experienced people can exercise their (in theory) better judgement, and everyone can benefit from less breakage. This is 95% of the work involved.
Is the user's build clean? - They'll be giving you a
mail_msg file, which will ideally be absolutely free of any noise. In practice there are times when there will be noise for other reasons not related to their integration. You should check!
mail_msgfile for the compilers that were actually used.
Be sure to do the following:
You can (and should) visually inspect outgoing commits before pushing (to ensure you have done all of the above) with something like:
git show --pretty=fuller origin/master..